Skip to content

CI: enable kcov on aarch64 #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

dianpopa
Copy link
Contributor

Reason for This PR

We tried replicating the variations seen in first phase by spawning multiple m6g and obtaining the coverage, however the value was always the same. We decided to enable the kcov test for the moment and solve the variations if/when the issue replicates again.

Description of Changes

[Author TODO: add description of changes.]

  • This functionality can be added in rust-vmm.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any newly added unsafe code is properly documented.
  • Any API changes are reflected in firecracker/swagger.yaml.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@dianpopa dianpopa self-assigned this Nov 27, 2020
@dianpopa dianpopa added Status: Awaiting review Indicates that a pull request is ready to be reviewed Feature: CPU Support: ARM labels Nov 30, 2020
Signed-off-by: Diana Popa <[email protected]>
@dianpopa dianpopa merged commit cc4759f into firecracker-microvm:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants