[v0.23.0] Cherry-pick commits #2186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <[email protected]>
Co-authored-by: georgepisaltu <[email protected]>
Fixed a bug in the virtio mechansim which could lead to the virtqueue reading stale data. Specifically, the virtqueue pop() function reads the index of the available ring tail from the driver in order to check for new descriptors made available. Based on that, it goes on to read the location of the available virtq descriptors. This introduces a load-load control dependency for which we need to protect against with a full memory barrier on weak memory models like arm. Signed-off-by: Diana Popa <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
|
Looks good, make sure you also link the issues fixed by the commits. |
sandreim
previously approved these changes
Oct 15, 2020
iulianbarbu
previously approved these changes
Oct 15, 2020
Signed-off-by: Iulian Barbu <[email protected]> Suggested-by: Andreea Florescu <[email protected]>
|
Edited the serial patch, now all tests pass. @iulianbarbu @sandreim please take another look. |
iulianbarbu
approved these changes
Oct 15, 2020
sandreim
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
Cherry pick relevant commits from master and v0.22.1 bug fix.
Description of Changes
Fixes possible load-load data inconsistency on arm.
Documentation updates for snapshotting.
Fixes #2177
rust-vmm.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.firecracker/swagger.yaml.CHANGELOG.md.