Skip to content

Firecracker release v0.20.0 #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 18, 2019
Merged

Conversation

serban300
Copy link
Contributor

@serban300 serban300 commented Nov 26, 2019

Reason for This PR

Firecracker release v0.20.0

Description of Changes

### Added

- Added support for GICv2.

### Fixed

- Fixed a logical error in bounds checking performed on vsock virtio
  descriptors (CVE-2019-18960).
- Fixed #1283 - Can't start a VM in AARCH64 with vcpus number more than 16.
- The backtrace are printed on `panic`, no longer causing a seccomp fault.
- Fixed #1375 - Change logger options type from Value to Vec<LogOption> to
  prevent potential unwrap on None panics.
- Raise interrupt for TX queue used descriptors - Github issue #1436
- Fixed a bug that causes 100% cpu load when the net device rx is throttled
  by the ratelimiter - Github issue #1439
- Invalid fields in rate limiter related API requests are now failing with
  a proper error message.
- Fixed #1316 - fix the size of a virtio device, backed by a block device.
- Log failed api requests.

### Changed

- Decreased release binary size by 10%.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

PR Checklist

[Author TODO: Meet these criteria. Where there are two options, keep one.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • Either this PR is linked to an issue, or, the reason for this PR is
    clearly provided.
  • The description of changes is clear and encompassing.
  • Either no docs need to be updated as part of this PR, or, the required
    doc changes are included in this PR. Docs in scope are all *.md files
    located either in the repository root, or in the docs/ directory.
  • Either no code has been touched, or, code-level documentation for touched
    code is included in this PR.
  • Either no API changes are included in this PR, or, the API changes are
    reflected in firecracker/swagger.yaml.
  • Either the changes in this PR have no user impact, or, the changes in
    this PR have user impact and have been added to the CHANGELOG.md file.
  • Either no new unsafe code has been added, or, the newly added unsafe
    code is unavoidable and properly documented.

@serban300 serban300 requested a review from a team November 26, 2019 10:57
@serban300 serban300 self-assigned this Nov 26, 2019
@serban300 serban300 force-pushed the release branch 2 times, most recently from aca8092 to 7dfa20b Compare November 26, 2019 11:20
dianpopa
dianpopa previously approved these changes Nov 26, 2019
@serban300 serban300 force-pushed the release branch 2 times, most recently from 471c27c to 24d4d24 Compare November 28, 2019 10:26
dianpopa
dianpopa previously approved these changes Nov 28, 2019
iulianbarbu
iulianbarbu previously approved these changes Nov 28, 2019
@sandreim sandreim self-requested a review November 28, 2019 11:04
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delay the release so I can merge a fix for #1436.

@dianpopa dianpopa added the Status: Blocked Indicates that an issue or pull request cannot currently be worked on label Dec 2, 2019
@andreeaflorescu
Copy link
Member

Can we resume the work on this release? All relevant blockers seem to be merged now.

@sandreim sandreim added Status: Author and removed Status: Blocked Indicates that an issue or pull request cannot currently be worked on labels Dec 12, 2019
@serban300 serban300 dismissed stale reviews from iulianbarbu and dianpopa via 0b58a02 December 13, 2019 10:38
@serban300 serban300 added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Author labels Dec 13, 2019
@sandreim sandreim dismissed their stale review December 13, 2019 23:08

All blocker PRs merged.

dianpopa
dianpopa previously approved these changes Dec 17, 2019
Copy link
Contributor

@dianpopa dianpopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I d like for us to use the same format across the entire changelog when associating a issue to a fixed entry.
Now we have

Fixes #12...
- GitHub issue #12...
(GitHub issue #12...)

Signed-off-by: Serban Iorga <[email protected]>
@acatangiu acatangiu merged commit 1374b26 into firecracker-microvm:master Dec 18, 2019
@serban300 serban300 deleted the release branch May 10, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants