Skip to content

remove DCO check on commits in buildkite pipeline #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2023
Merged

remove DCO check on commits in buildkite pipeline #502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions .buildkite/logcheck.sh
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,6 @@ steps:
distro: "${BUILDKITE_AGENT_META_DATA_DISTRO}"
hostname: "${BUILDKITE_AGENT_META_DATA_HOSTNAME}"

- label: 'git log validation'
command: './.buildkite/logcheck.sh'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that script also checks fixup commits. will it be migrated and covered by GH actions too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add that check using GH action as well. However, IMO we can just get rid of it. As reviewers we often check the commits and make sure that they are squashed before merging.

# This should run in the same queue, but we don't care whether it runs on
# the same host.
agents:
queue: "${BUILDKITE_AGENT_META_DATA_QUEUE:-default}"

# This makes sure next step will run even if previous steps failed
# to make sure we can reach the final step for resource cleanup
- wait: ~
Expand Down