Fix CI build by using pre-built rootfs image #488
Conversation
fangn2
force-pushed
the
fix-build
branch
4 times, most recently
from
1645a32 to
5523649
Compare
examples/cmd/snapshotting/Makefile
Outdated
| cp temp/build/rootfs/ssh/id_rsa root-drive-ssh-key | ||
| rm -rf temp | ||
|
|
||
| curl -L -o root-drive-with-ssh.img https://s3.amazonaws.com/spec.ccfc.min/ci-artifacts/disks/${ARCH}/ubuntu-18.04.ext4 |
There was a problem hiding this comment.
devtool is using ubuntu 22.04, correct? We should keep the same upgraded version here imo.
There was a problem hiding this comment.
Current HEAD of firecracker uses 22.04. Older versions of firecracker use 18.04.
Current issue is firecracker didn't publish ubuntu-22.04.ext4 in the same S3 bucket.
I can follow up with them and address this in a follow-up PR?
fangn2
force-pushed
the
fix-build
branch
2 times, most recently
from
f2ed91e to
13d7450
Compare
| # Download Firecracker and its jailer. | ||
| - make deps | ||
| # Build a rootfs with SSH enabled. | ||
| - sudo -E FC_TEST_DATA_PATH=${FC_TEST_DATA_PATH} make ${FC_TEST_DATA_PATH}/root-drive-ssh-key |
There was a problem hiding this comment.
With pre-built rootfs, we no longer need to build them with root, now they are part of deps build(check Makrfile changes below)
|
Updated few other parts(please check Description of changes for details) to pass the build. CI seems a little bit unstable when it ran step |
fangn2
force-pushed
the
fix-build
branch
3 times, most recently
from
b3033e8 to
6c0ab8f
Compare
There was a problem hiding this comment.
Minor nits, otherwise looks good.
We are using hello-rootfs.ext4 for non-ssh testing, which I believe is also uploaded by firecracker team. Lets confirm what OS version this is based of and whether FC team can do something similar for ssh version, i.e. with OS agnostic naming.
By not hardcoding distro name and switching to pre-built rootfs image instead of using devtool which is unstable Signed-off-by: Tony Fang <[email protected]>
Issue #, if available:
#418
The main branch is failing due to hardcoded rootfs name as the name changed with upstream firecracker moving from bionic to jammy. Also devtool used to build rootfs is unstable.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Signed-off-by: Tony Fang [email protected]