Add critest to Makefile and Docker test image #563
Conversation
ginglis13
force-pushed
the
makefile-critest
branch
2 times, most recently
from
1e11ca7 to
b142044
Compare
ginglis13
changed the title
| @@ -256,8 +256,12 @@ TEST_BRIDGED_TAP_BIN?=$(BINPATH)/test-bridged-tap | |||
| $(TEST_BRIDGED_TAP_BIN): $(shell find internal/cmd/test-bridged-tap -name *.go) $(GOMOD) $(GOSUM) | |||
| go build -o $@ $(CURDIR)/internal/cmd/test-bridged-tap | |||
|
|
|||
| LOOPBACK_BIN?=$(BINPATH)/loopback | |||
| $(LOOPBACK_BIN): | |||
| GOBIN=$(dir $@) GO111MODULE=off go get -u github.com/containernetworking/plugins/plugins/main/loopback | |||
There was a problem hiding this comment.
Is it possible to pin the version of loopback? I believe go get is going to fetch the latest version.
There was a problem hiding this comment.
Yea, go get will get version @ latest . I was following how we currently get/install other container networking plugins:
firecracker-containerd/Makefile
Lines 235 to 249 in 3c25750
Do we want to be able to pin a version for each of these as well? Can take that up as a separate issue.
There was a problem hiding this comment.
Oh okay. I'm fine doing that in a separate PR in this case.
| critest: | ||
| $(CURDIR)/../tools/thinpool.sh reset "$(FICD_DM_POOL)" | ||
| docker run --rm -it \ | ||
| --privileged \ |
There was a problem hiding this comment.
Does it work with --network=none?
There was a problem hiding this comment.
as I have right now, it does not work with --network=none because critest need to pull an image for creating Pod sandboxes. Would it be best to pull this sandbox image into FIRECRACKER_CONTAINERD_TEST_IMAGE , then ?
There was a problem hiding this comment.
I see. It would be better to keep that as is. Technically we could pull some images beforehand, but that may make critest less useful, assuming we might break the pulling part someday.
There was a problem hiding this comment.
Ok yes and just more on that, the sandbox image could be predownloading but networking would still have to be enable as there are tests for pulling images too (e.g. [It] public image with tag should be pulled and removed)
So for now I think we'll have to enable networking for this test.
tools/docker/Dockerfile.integ-test
Outdated
| RUN wget https://github.com/kubernetes-sigs/cri-tools/releases/download/$VERSION/critest-$VERSION-linux-amd64.tar.gz | ||
| RUN tar zxvf critest-$VERSION-linux-amd64.tar.gz -C /tmp/ | ||
| RUN install -D -o root -g root -m755 -t /usr/local/bin /tmp/critest | ||
| RUN rm -f critest-$VERSION-linux-amd64.tar.gz | ||
|
|
||
| RUN wget https://github.com/kubernetes-sigs/cri-tools/releases/download/$VERSION/crictl-$VERSION-linux-amd64.tar.gz | ||
| RUN tar zxvf crictl-$VERSION-linux-amd64.tar.gz -C /tmp/ | ||
| RUN install -D -o root -g root -m755 -t /usr/local/bin /tmp/crictl | ||
| RUN rm -f crictl-$VERSION-linux-amd64.tar.gz |
There was a problem hiding this comment.
Let's put them in single RUN. https://hackernoon.com/tips-to-reduce-docker-image-sizes-876095da3b34
ginglis13
force-pushed
the
makefile-critest
branch
from
b142044 to
4148086
Compare
tools/docker/Dockerfile.integ-test
Outdated
| RUN wget https://github.com/kubernetes-sigs/cri-tools/releases/download/$VERSION/critest-$VERSION-linux-amd64.tar.gz && \ | ||
| tar zxvf critest-$VERSION-linux-amd64.tar.gz -C /tmp/ && \ | ||
| install -D -o root -g root -m755 -t /usr/local/bin /tmp/critest && \ | ||
| rm -f critest-$VERSION-linux-amd64.tar.gz && \ |
Add critest tool to test-images and invoke in Dockerfile. Add rule to Makefile for running critest Preliminary step before adding critest to BuildKite pipeline. Signed-off-by: Gavin Inglis <[email protected]>
ginglis13
force-pushed
the
makefile-critest
branch
from
4148086 to
88af59f
Compare
Description of changes:
Add critest tool and dependencies to Docker test image.
Add rule to Makefile for running critest.
Preliminary step before adding CRI conformance testing to BuildKite pipeline.
Testing
Locally, modified
entrypoint.shto use local pool, in my casepool_name = fc-test-thinpool, ->make -C runtime critest. Errors reported by critest at the moment typically all connection refused when dialing firecracker.vsock . Checking logs within the container, looks like fc VMs are hitting a kernel panic:/bin/sh: 0: cannot open nomodules: No such file [ 0.936147] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000200Issue #, if available:
Related: #88
Signed-off-by: Gavin Inglis [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.