Updated taskworkflow.go: fixes in socket name and readme. #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think our Docker image is still running firecracker-containerd on |
|
@kzys shall we change and then add --config option to would it be the right way? |
|
@ustiugov That's the right way, but you don't need to pass |
ustiugov
force-pushed
the
taskworkflow_fixes
branch
3 times, most recently
from
8e7adf5 to
7e6f53d
Compare
Socket name was aligned with the quickstart guidelines (in integration tests as well). Removed the mask argument from the readme as it is not supported anymore. Signed-off-by: Dmitrii Ustiugov <[email protected]>
ustiugov
force-pushed
the
taskworkflow_fixes
branch
from
7e6f53d to
4b3f8a7
Compare
|
@kzys feedback applied, tests pass. Could you please check? |
kzys
approved these changes
Mar 23, 2020
fangn2
pushed a commit
to fangn2/firecracker-containerd
that referenced
this pull request
Mar 23, 2023
Allow passing cgroup-version to jailer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #387 *
Description of changes:
Socket name was aligned with the quickstart guidelines. Removed the
-maskargument from the readme as it is not supported anymore. Specified that-ipargument requires CIDR and not just an IP address.Signed-off-by: Dmitrii Ustiugov [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.