-
Notifications
You must be signed in to change notification settings - Fork 200
Remove snapshotter package #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The change looks good to me. Would it be helpful to tag current master (0.1.0 or "naive-snapshotter") for accessing naive snapshotter someday/someone? I'm unsure how useful the snapshotter for others though. |
The getting started guide and quickstart guides both need updates as they still refer to the naive snapshotter, other than that LGTM |
I don't see a reason to leave the guides in a broken state (even if it's just temporary) as it's not like deleting the snapshotter code is a time-sensitive emergency. Can we just do the bare minimum in this PR to make sure the guides still work (i.e. don't have references to the naive snapshotter that no longer exists) and then do further cleanup in the follow-up PRs? |
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
…irecracker-microvm#341)" (firecracker-microvm#344) This reverts commit 647aa41. This commit includes two changes:update slack url + update yaml that should commit separately. Signed-off-by: Royce Zhao <[email protected]>
Issue #, if available:
#318
Description of changes:
This removes snapshotter package code from our repo.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.