Skip to content

Remove snapshotter package #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 29, 2019
Merged

Remove snapshotter package #344

merged 7 commits into from
Nov 29, 2019

Conversation

mxpv
Copy link
Contributor

@mxpv mxpv commented Nov 26, 2019

Issue #, if available:
#318

Description of changes:
This removes snapshotter package code from our repo.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kzys
Copy link
Contributor

kzys commented Nov 26, 2019

The change looks good to me. Would it be helpful to tag current master (0.1.0 or "naive-snapshotter") for accessing naive snapshotter someday/someone? I'm unsure how useful the snapshotter for others though.

@sipsma
Copy link
Contributor

sipsma commented Nov 26, 2019

The getting started guide and quickstart guides both need updates as they still refer to the naive snapshotter, other than that LGTM

@mxpv
Copy link
Contributor Author

mxpv commented Nov 26, 2019

@sipsma There are a couple more tasks I'm planning to do, including updating docs, in follow up PRs (list is here #318)

@kzys we can, but I'd rather name it naive-snapshotter or something, instead of 0.1.0, so it won't be confused with release update.

@sipsma
Copy link
Contributor

sipsma commented Nov 26, 2019

@sipsma There are a couple more tasks I'm planning to do, including updating docs, in follow up PRs (list is here #318)

I don't see a reason to leave the guides in a broken state (even if it's just temporary) as it's not like deleting the snapshotter code is a time-sensitive emergency. Can we just do the bare minimum in this PR to make sure the guides still work (i.e. don't have references to the naive snapshotter that no longer exists) and then do further cleanup in the follow-up PRs?

mxpv added 7 commits November 29, 2019 13:51
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
@mxpv mxpv merged commit e80d4cc into firecracker-microvm:master Nov 29, 2019
@mxpv mxpv deleted the dm-rm branch November 29, 2019 22:47
@mxpv mxpv mentioned this pull request Dec 12, 2019
5 tasks
fangn2 pushed a commit to fangn2/firecracker-containerd that referenced this pull request Mar 23, 2023
…irecracker-microvm#341)" (firecracker-microvm#344)

This reverts commit 647aa41.
This commit includes two changes:update slack url + update yaml that should commit separately.

Signed-off-by: Royce Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants