Adds cgroup path to CreateVMResponse #306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xibz
requested review from
kzys,
nmeyerhans,
samuelkarp,
mxpv,
IRCody and
sipsma
IRCody
previously requested changes
Oct 25, 2019
sipsma
reviewed
Oct 25, 2019
xibz
force-pushed
the
jailer-cgroup-path-clean
branch
from
9131747 to
1ab7574
Compare
xibz
force-pushed
the
jailer-cgroup-path-clean
branch
from
213a9b4 to
2d3dfdc
Compare
xibz
force-pushed
the
jailer-cgroup-path-clean
branch
4 times, most recently
from
2172cb4 to
99fd463
Compare
sipsma
reviewed
Nov 14, 2019
xibz
force-pushed
the
jailer-cgroup-path-clean
branch
3 times, most recently
from
cc3df84 to
ca8fa6c
Compare
kzys
approved these changes
Nov 15, 2019
xibz
force-pushed
the
jailer-cgroup-path-clean
branch
2 times, most recently
from
2e4e8c5 to
3512b7a
Compare
sipsma
approved these changes
Nov 18, 2019
This commit adds a response to CreateVM. The CreateVMResponse contains the CgroupPath field that will be returned when jailing is enabled. Signed-off-by: xibz <[email protected]>
xibz
force-pushed
the
jailer-cgroup-path-clean
branch
from
3512b7a to
7fe8c50
Compare
xibz
dismissed
IRCody’s stale review
I believe Cody has already marked these as resolved or I may have. Either way, they've been resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a response to CreateVM. The CreateVMResponse contains
the CgroupPath field that will be returned when jailing is enabled.
Signed-off-by: xibz [email protected]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.