The rootfs of a microVM should be read-only #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xibz
suggested changes
Oct 11, 2019
samuelkarp
reviewed
Oct 11, 2019
sipsma
reviewed
Oct 11, 2019
samuelkarp
reviewed
Oct 11, 2019
kzys
added a commit
to kzys/firecracker-go-sdk
that referenced
this pull request
Oct 11, 2019
The would make firecracker-microvm/firecracker-containerd#283 cleaner. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
added a commit
to kzys/firecracker-go-sdk
that referenced
this pull request
Oct 11, 2019
This would make firecracker-microvm/firecracker-containerd#283 cleaner. Signed-off-by: Kazuyoshi Kato <[email protected]>
While customers can make it writable by sending a request, the rootfs should be read-only to reduce our attack surface. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
force-pushed
the
read-only
branch
3 times, most recently
from
6de89ed to
f31fd30
Compare
xibz
suggested changes
Oct 15, 2019
xibz
reviewed
Oct 15, 2019
xibz
reviewed
Oct 15, 2019
kzys
force-pushed
the
read-only
branch
2 times, most recently
from
56734d8 to
df38500
Compare
In proto3, all omitted boolean values are considered as false! This change allows makes the default mode of a drive read-only, even if the flag is omitted. Signed-off-by: Kazuyoshi Kato <[email protected]>
Signed-off-by: Kazuyoshi Kato <[email protected]>
xibz
pushed a commit
to xibz/firecracker-go-sdk
that referenced
this pull request
Nov 5, 2019
This would make firecracker-microvm/firecracker-containerd#283 cleaner. Signed-off-by: Kazuyoshi Kato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
NA
Description of changes:
While customers won't be able to access the rootfs, making it read-only
will reduce its attack surface.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.