Skip to content

Use docker's --init as is #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Conversation

kzys
Copy link
Contributor

@kzys kzys commented Aug 21, 2019

Issue #, if available:

Description of changes:

Docker no longer uses /dev/init as init. So, we can use --init instead
of installing our own tini binary.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Docker no longer uses /dev/init as init. So, we can use --init instead
of installing our own tini binary.

Signed-off-by: Kazuyoshi Kato <[email protected]>
Copy link
Contributor

@sipsma sipsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad they finally fixed that

@kzys kzys merged commit 9ac2c29 into firecracker-microvm:master Aug 21, 2019
@kzys kzys deleted the remove-tini-2 branch August 21, 2019 19:10
fangn2 pushed a commit to fangn2/firecracker-containerd that referenced this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants