runtime: specify default kernel arguments #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: firecracker-microvm#59 Signed-off-by: Samuel Karp <[email protected]>
mxpv
reviewed
Mar 20, 2019
| defer cleanup() | ||
| cfg, err := LoadConfig(configFile) | ||
| if err != nil { | ||
| t.Error(err, "failed to load config") |
There was a problem hiding this comment.
nit: can be just assert.NoError
fangn2
pushed a commit
to fangn2/firecracker-containerd
that referenced
this pull request
Mar 23, 2023
Define functional options for DrivesBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#59
Description of changes:
Sets default kernel arguments so that it is not required to specify.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.