runtime: hard-code Firecracker API socket path #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Firecracker API socket is important for the runtime, as it uses the socket to communicate with Firecracker. Allowing the runtime to fully control the API socket (including its path) removes a potential failure condition from misconfiguration. The API socket is hard-coded to exist within the current working directory. Part of the contract that containerd exposes for runtimes is that they are started with the current working directory changed to be that of the OCI bundle. Using an API socket in the OCI bundle makes its location well-known and predictable to the runtime. Related: firecracker-microvm#59 Related: firecracker-microvm/firecracker-go-sdk#88 Signed-off-by: Samuel Karp <[email protected]>
|
Would this require us to have separate runtime instance per microVM? |
|
It does right now, as that's the way the runtime works today. I know that we're thinking about changing the way the runtime works, but we don't yet know fully what we plan to do. I think having the socket path defined in the global config file is bad as it makes it too easy to misconfigure and conflict. If we do decide to have a single runtime, we can revisit this then and add it to whatever API is used to configure the runtime rather than a global config file. |
mxpv
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#59
Description of changes:
The Firecracker API socket is important for the runtime, as it uses the socket to communicate with Firecracker. Allowing the runtime to fully control the API socket (including its path) removes a potential failure condition from misconfiguration.
The API socket is hard-coded to exist within the current working directory. Part of the contract that containerd exposes for runtimes is that they are started with the current working directory changed to be that of the OCI bundle. Using an API socket in the OCI bundle makes its location well-known and predictable to the runtime.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.