Skip to content

Support RateLimiters and ReadOnly for DriveMounts #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sipsma opened this issue Oct 17, 2019 · 0 comments · Fixed by #332
Closed

Support RateLimiters and ReadOnly for DriveMounts #296

sipsma opened this issue Oct 17, 2019 · 0 comments · Fixed by #332
Assignees
@sipsma
Labels
kind/enhancement New feature or request

Comments

@sipsma
Copy link
Contributor

sipsma commented Oct 17, 2019

The first iteration of support for DriveMounts leaves out RateLimiter and IsReadOnly settings for the drives due to the fact that doing so requires significant refactoring of the stubdrive code (as RateLimiter and IsReadOnly settings cannot be updated via a Patch call).

Right now, users can still specify that a filesystem be bind-mounted as read-only into their container, but they don't have any options for the rate-limiter currently.
@sipsma sipsma self-assigned this Oct 17, 2019
@sipsma sipsma added the kind/enhancement New feature or request label Oct 17, 2019
sipsma added a commit to sipsma/firecracker-containerd that referenced this issue Oct 17, 2019
@sipsma
Support DriveMount API in CreateVM.
51b4aa1 
This implements the proposal found in docs/drive-mounts-proposal.md, with the
exception for supporting RateLimiters and IsReadOnly in the DriveMount objects,
due to the need for further refactoring of the internal stub drive code (will
be followed up in firecracker-microvm#296).

Signed-off-by: Erik Sipsma <[email protected]>
@sipsma sipsma mentioned this issue Oct 17, 2019
Merged
sipsma added a commit to sipsma/firecracker-containerd that referenced this issue Oct 21, 2019
@sipsma
Support DriveMount API in CreateVM.
f375d41 
This implements the proposal found in docs/drive-mounts-proposal.md, with the
exception for supporting RateLimiters and IsReadOnly in the DriveMount objects,
due to the need for further refactoring of the internal stub drive code (will
be followed up in firecracker-microvm#296).

Signed-off-by: Erik Sipsma <[email protected]>
sipsma added a commit to sipsma/firecracker-containerd that referenced this issue Oct 21, 2019
@sipsma
Support DriveMount API in CreateVM.
d871b89 
This implements the proposal found in docs/drive-mounts-proposal.md, with the
exception for supporting RateLimiters and IsReadOnly in the DriveMount objects,
due to the need for further refactoring of the internal stub drive code (will
be followed up in firecracker-microvm#296).

Signed-off-by: Erik Sipsma <[email protected]>
sipsma added a commit to sipsma/firecracker-containerd that referenced this issue Oct 24, 2019
@sipsma
Support DriveMount API in CreateVM.
807b42b 
This implements the proposal found in docs/drive-mounts-proposal.md, with the
exception for supporting RateLimiters and IsReadOnly in the DriveMount objects,
due to the need for further refactoring of the internal stub drive code (will
be followed up in firecracker-microvm#296).

Signed-off-by: Erik Sipsma <[email protected]>
sipsma added a commit to sipsma/firecracker-containerd that referenced this issue Oct 24, 2019
@sipsma
Support DriveMount API in CreateVM.
0f7ac63 
This implements the proposal found in docs/drive-mounts-proposal.md, with the
exception for supporting RateLimiters and IsReadOnly in the DriveMount objects,
due to the need for further refactoring of the internal stub drive code (will
be followed up in firecracker-microvm#296).

Signed-off-by: Erik Sipsma <[email protected]>
sipsma added a commit to sipsma/firecracker-containerd that referenced this issue Oct 25, 2019
@sipsma
Support DriveMount API in CreateVM.
58a2d94 
This implements the proposal found in docs/drive-mounts-proposal.md, with the
exception for supporting RateLimiters and IsReadOnly in the DriveMount objects,
due to the need for further refactoring of the internal stub drive code (will
be followed up in firecracker-microvm#296).

Signed-off-by: Erik Sipsma <[email protected]>
@sipsma sipsma mentioned this issue Nov 6, 2019
Closed
sipsma added a commit to sipsma/firecracker-containerd that referenced this issue Nov 6, 2019
@sipsma
Support DriveMount API in CreateVM.
999773d 
This implements the proposal found in docs/drive-mounts-proposal.md, with the
exception for supporting RateLimiters and IsReadOnly in the DriveMount objects,
due to the need for further refactoring of the internal stub drive code (will
be followed up in firecracker-microvm#296).

Signed-off-by: Erik Sipsma <[email protected]>
sipsma added a commit to sipsma/firecracker-containerd that referenced this issue Nov 7, 2019
@sipsma
Support DriveMount API in CreateVM.
c381fcb 
This implements the proposal found in docs/drive-mounts-proposal.md, with the
exception for supporting RateLimiters and IsReadOnly in the DriveMount objects,
due to the need for further refactoring of the internal stub drive code (will
be followed up in firecracker-microvm#296).

Signed-off-by: Erik Sipsma <[email protected]>
@sipsma sipsma mentioned this issue Nov 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sipsma sipsma

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support rate-limiters and read-only for drive mounts. sipsma/firecracker-containerd
1 participant
@sipsma