Merge pull request #298 from kzys/test-limits

Test that the size of a root drive is capped

Author: kzys

runtime/integ_test.go

@@ -13,12 +13,17 @@
 package main
 
 import (
+	"bytes"
+	"context"
 	"encoding/json"
 	"os"
 	"strings"
 	"testing"
 
+	"github.com/containerd/containerd"
+	"github.com/containerd/containerd/cio"
 	"github.com/firecracker-microvm/firecracker-containerd/internal"
+	"github.com/pkg/errors"
 )
 
 const runtimeConfigPath = "/etc/containerd/firecracker-runtime.json"
@@ -90,3 +95,49 @@ var testNameToVMIDReplacer = strings.NewReplacer("/", "_")
 func testNameToVMID(s string) string {
 	return testNameToVMIDReplacer.Replace(s)
 }
+
+type commandResult struct {
+	stdout   string
+	stderr   string
+	exitCode uint32
+}
+
+func runTask(ctx context.Context, c containerd.Container) (*commandResult, error) {
+	var stdout bytes.Buffer
+	var stderr bytes.Buffer
+
+	task, err := c.NewTask(ctx, cio.NewCreator(cio.WithStreams(nil, &stdout, &stderr)))
+	if err != nil {
+		return nil, err
+	}
+
+	exitCh, err := task.Wait(ctx)
+	if err != nil {
+		return nil, err
+	}
+
+	err = task.Start(ctx)
+	if err != nil {
+		return nil, err
+	}
+
+	select {
+	case exitStatus := <-exitCh:
+		if err := exitStatus.Error(); err != nil {
+			return nil, err
+		}
+
+		_, err := task.Delete(ctx)
+		if err != nil {
+			return nil, err
+		}
+
+		return &commandResult{
+			stdout:   stdout.String(),
+			stderr:   stderr.String(),
+			exitCode: exitStatus.ExitCode(),
+		}, nil
+	case <-ctx.Done():
+		return nil, errors.New("context cancelled")
+	}
+}

runtime/limits_integ_test.go

@@ -0,0 +1,66 @@
+// Copyright 2018-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License"). You may
+// not use this file except in compliance with the License. A copy of the
+// License is located at
+//
+//	http://aws.amazon.com/apache2.0/
+//
+// or in the "license" file accompanying this file. This file is distributed
+// on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
+// express or implied. See the License for the specific language governing
+// permissions and limitations under the License.
+package main
+
+import (
+	"context"
+	"testing"
+
+	"github.com/containerd/containerd"
+	"github.com/containerd/containerd/namespaces"
+	"github.com/containerd/containerd/oci"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestDiskLimit_Isolated(t *testing.T) {
+	prepareIntegTest(t)
+
+	assert := assert.New(t)
+	require := require.New(t)
+
+	ctx := namespaces.WithNamespace(context.Background(), "default")
+
+	client, err := containerd.New(containerdSockPath, containerd.WithDefaultRuntime(firecrackerRuntime))
+	require.NoError(err, "unable to create client to containerd service at %s, is containerd running?", containerdSockPath)
+	defer client.Close()
+
+	image, err := alpineImage(ctx, client, defaultSnapshotterName())
+	require.NoError(err, "failed to get alpine image")
+
+	// Right now, both naive snapshotter and devmapper snapshotter are configured to have 1024MB image size.
+	// The former is hard-coded since the snapshotter is not for production. The latter is configured in tools/docker/entrypoint.sh.
+	sh := containerd.WithNewSpec(
+		oci.WithProcessArgs("dd", "if=/dev/zero", "of=/tmp/fill", "bs=1M", "count=2000"),
+		oci.WithDefaultPathEnv,
+	)
+
+	container, err := client.NewContainer(ctx,
+		"container",
+		containerd.WithSnapshotter(defaultSnapshotterName()),
+		containerd.WithNewSnapshot("snapshot", image),
+		sh,
+	)
+	defer func() {
+		err = container.Delete(ctx, containerd.WithSnapshotCleanup)
+		require.NoError(err, "failed to delete a container")
+	}()
+
+	result, err := runTask(ctx, container)
+	require.NoError(err, "failed to create a container")
+
+	assert.Equal(uint32(1), result.exitCode, "writing 2GB must fail")
+	assert.Equal(`952+0 records in
+951+0 records out
+`, result.stderr, "but it must be able to write ~1024MB")
+}

tools/docker/entrypoint.sh

@@ -26,7 +26,7 @@ EOF
 [plugins]
   [plugins.devmapper]
     pool_name = "fcci--vg-${FICD_DM_POOL}"
-    base_image_size = "128MB"
+    base_image_size = "1024MB"
 EOF
         ;;
     *)