Skip to content

Commit 5f3e0c7

Browse files
authored
Merge pull request #329 from kzys/clean-logs
Declutter logs
2 parents 8e3e3c4 + df2d580 commit 5f3e0c7

File tree

4 files changed

+3
-5
lines changed

4 files changed

+3
-5
lines changed

runtime/integ_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const runtimeConfigPath = "/etc/containerd/firecracker-runtime.json"
2626
var defaultRuntimeConfig = Config{
2727
FirecrackerBinaryPath: "/usr/local/bin/firecracker",
2828
KernelImagePath: "/var/lib/firecracker-containerd/runtime/default-vmlinux.bin",
29-
KernelArgs: "ro console=ttyS0 noapic reboot=k panic=1 pci=off nomodules systemd.journald.forward_to_console systemd.unit=firecracker.target init=/sbin/overlay-init",
29+
KernelArgs: "ro console=ttyS0 noapic reboot=k panic=1 pci=off nomodules systemd.journald.forward_to_console systemd.log_color=false systemd.unit=firecracker.target init=/sbin/overlay-init",
3030
RootDrive: "/var/lib/firecracker-containerd/runtime/default-rootfs.img",
3131
CPUCount: 1,
3232
CPUTemplate: "T2",

runtime/service.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ func (s *service) StartShim(shimCtx context.Context, containerID, containerdBina
328328

329329
log.Info("will start a single-task VM since no VMID has been provided")
330330
} else {
331-
log.Info("will start a persistent VM")
331+
log.WithField("vmID", s.vmID).Info("will start a persistent VM")
332332
}
333333

334334
client, err := ttrpcutil.NewClient(containerdTTRPCAddress)

tools/docker/entrypoint.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#!/usr/bin/env bash
2-
set -ex
2+
set -e
33

44
chmod a+rwx ${FICD_LOG_DIR}
55

tools/image-builder/files_debootstrap/sbin/overlay-init

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
# express or implied. See the License for the specific language governing
1313
# permissions and limitations under the License.
1414

15-
set -x
16-
1715
# Parameters:
1816
# 1. rw_root -- path where the read/write root is mounted
1917
# 2. work_dir -- path to the overlay workdir (must be on same filesystem as rw_root)

0 commit comments

Comments
 (0)