This repository was archived by the owner on Dec 30, 2024. It is now read-only.
Snippets for new Admin auth features #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsgowman
reviewed
Apr 1, 2020
|
|
||
| public void getUserByFederatedId() throws Exception { | ||
| // [START get_user_by_federated_id] | ||
| UserRecord user = FirebaseAuth.getInstance().getUserByFederatedIdAsync("google.com", "google_uid1234").get(); |
There was a problem hiding this comment.
This should be getUserByProviderUidAsync (similar to the other ports). Yeah, I see that the upstream PR where you got this from is also incorrect and have flagged that.
admin/src/main/java/com/google/firebase/example/FirebaseAuthSnippets.java
Outdated
Show resolved
Hide resolved
admin/src/main/java/com/google/firebase/example/FirebaseAuthSnippets.java
Outdated
Show resolved
Hide resolved
admin/src/main/java/com/google/firebase/example/FirebaseAuthSnippets.java
Outdated
Show resolved
Hide resolved
|
@rsgowman any update on this? |
|
There's still one comment left to be addressed? (Mind you, upstream hasn't addressed it yet either; I haven't been pushing on it since we don't have the launch approval finalized. Though perhaps that was what you were asking about? More context: additionally, these features depend on the bulk get/delete feature, which is only rolling out "now".) |
|
@rsgowman yeah I was asking when the upstream PRs would be merged so that we can write this on top of the real SDK. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on:
firebase/snippets-node#94
Depends on:
firebase/firebase-admin-java#340
firebase/firebase-admin-java#345