feat(py): Added the render_system_prompt function and the dotprompt i… #3503
Conversation
…nstance to registry
| """Renders a prompt using dotprompt.""" | ||
| rendered = await prompt_function(input_) | ||
|
|
||
| if 1 < len(rendered.messages): |
There was a problem hiding this comment.
| if 1 < len(rendered.messages): | |
| if len(rendered.messages) > 1: |
|
@hendrixmar can we please address the python checks that are failing? |
| @@ -408,3 +437,53 @@ def _normalize_prompt_arg( | |||
| return prompt | |||
| else: | |||
| return [prompt] | |||
|
|
|||
|
|
|||
| async def render_system_prompt(registry: Registry, input_: Any, options: PromptConfig) -> Message: | |||
There was a problem hiding this comment.
input type can be str | Part | list[Part] | PartsResolver, right?
There was a problem hiding this comment.
In the JS implementation I see that it is z.infer and in the Golang it use map[string]any
so not sure which one to use
|
|
||
| elif isinstance(options.system, str): | ||
|
|
||
| user_prompt = await registry.dotprompt.compile(input_) |
There was a problem hiding this comment.
It would be great to if we could cache the compiled dotprompt template. Otherwise we have to compile it on every invocation.
There was a problem hiding this comment.
Yes, I reviewed that part from the JS implementation, and I was wondering if that object was already defined in the Python implementation. I searched using the same name and I haven't found anything close to that
…nstance to registry
Description here... Help the reviewer by:
Checklist (if applicable):