[Editor] Remove the Editor EAP files

[a-maurice]

Description

Provide details of the change, and generalize the change in the PR title above.

Remove the EAP editor files, they haven't been enabled for years now. If we want to bring it back, we can just use the git history.

---

Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/15006524237

---

Type of Change

Place an x the applicable box:

• Bug fix. Add the issue # below if applicable.
• New feature. A non-breaking change which adds functionality.
• Other, such as a build process or documentation change.

---

[gemini-code-assist]

Hello @a-maurice, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request removes the Early Access Program (EAP) files for the Unity Editor. According to the description, these files haven't been enabled for years, and the author suggests that if they are needed again, they can be retrieved from the Git history. The changes involve removing several subdirectories from the editor/CMakeLists.txt file and deleting entire files related to the EAP version of the editor for Analytics, Authentication, and Dynamic Links.

Highlights

• Cleanup: Removes unused EAP editor files to reduce clutter and potential confusion.
• CMake Configuration: Updates the CMakeLists.txt file to remove references to the EAP subdirectories.
• Code Removal: Deletes the source code, resource files, and configurations associated with the EAP editor.

Changelog

Click here to see the changelog

• editor/CMakeLists.txt
  • Removed analytics, auth, and dynamic_links subdirectories.
• editor/Firebase.Analytics.Editor.cmake
  • Deleted the entire file, which contained CMake configurations for the Firebase Analytics Unity editor plugin's EAP version.
• editor/Firebase.Auth.Editor.AuthConfig.cs
  • Deleted the entire file, which contained configuration settings for Firebase Authentication in the Unity Editor.
• editor/Firebase.Auth.Editor.Empty.cs
  • Deleted the entire file, which was likely a placeholder to resolve build issues for non-EAP builds.
• editor/Firebase.Auth.Editor.Strings.Designer.cs
  • Deleted the entire file, which was an auto-generated file for localized strings used in the Firebase Authentication editor.
• editor/Firebase.Auth.Editor.Strings.resx
  • Deleted the entire file, which contained resources for localized strings used in the Firebase Authentication editor.
• editor/Firebase.Auth.Editor.cmake
  • Deleted the entire file, which contained CMake configurations for the Firebase Authentication Unity editor plugin's EAP version.
• editor/Firebase.DynamicLinks.Editor.DynamicLinksConfig.cs
  • Deleted the entire file, which contained configuration settings for Firebase Dynamic Links in the Unity Editor.
• editor/Firebase.DynamicLinks.Editor.Empty.cs
  • Deleted the entire file, which was likely a placeholder to resolve build issues for non-EAP builds.
• editor/Firebase.DynamicLinks.Editor.Strings.Designer.cs
  • Deleted the entire file, which was an auto-generated file for localized strings used in the Firebase Dynamic Links editor.
• editor/Firebase.DynamicLinks.Editor.Strings.resx
  • Deleted the entire file, which contained resources for localized strings used in the Firebase Dynamic Links editor.
• editor/Firebase.DynamicLinks.Editor.cmake
  • Deleted the entire file, which contained CMake configurations for the Firebase Dynamic Links Unity editor plugin's EAP version.
• editor/Firebase.Editor.ConfigApi.cs
  • Deleted the entire file, which provided an API for configuring Firebase extensions in the Unity Editor.
• editor/Firebase.Editor.ConfigWindow.cs
  • Deleted the entire file, which implemented the configuration window for Firebase extensions in the Unity Editor.
• editor/Firebase.Messaging.Editor.MessagingConfig.cs
  • Deleted the entire file, which contained configuration settings for Firebase Messaging in the Unity Editor.
• editor/Firebase.Messaging.Editor.Strings.Designer.cs
  • Deleted the entire file, which was an auto-generated file for localized strings used in the Firebase Messaging editor.
• editor/Firebase.Messaging.Editor.Strings.resx
  • Deleted the entire file, which contained resources for localized strings used in the Firebase Messaging editor.
• editor/app/CMakeLists.txt
  • Removed conditional compilation for EAP code.
  • Removed ${firebase_app_editor_eap_src} from the list of source files.
• editor/messaging/CMakeLists.txt
  • Removed conditional compilation for EAP code.
  • Removed ${firebase_messaging_editor_eap_src} from the list of source files.
• editor/src/AnalyticsConfig.cs
  • Deleted the entire file, which contained configuration settings for Firebase Analytics in the Unity Editor.
• editor/src/Empty.cs
  • Deleted the entire file, which was likely a placeholder to resolve build issues for non-EAP builds.
• editor/src/Strings.Designer.cs
  • Deleted the entire file, which was an auto-generated file for localized strings used in the Firebase Analytics editor.
• editor/src/Strings.resx
  • Deleted the entire file, which contained resources for localized strings used in the Firebase Analytics editor.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

An editor's code, now gone,
EAP's reign, a fading dawn.
Git's memory stays,
For future days,
If needed, it will be reborn.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request aims to remove the Editor EAP files, which haven't been enabled for years. This cleanup is a good step to reduce code clutter and improve maintainability. The changes seem straightforward, involving the removal of several subdirectories and related code blocks. However, a closer look reveals some potential areas for improvement and clarification.

Summary of Findings

• Missing Contextual Comments: The removal of EAP-related code lacks sufficient comments explaining the rationale behind the removal and pointers to the git history for future reference.

Merge Readiness

The pull request is mostly ready for merging, but adding the suggested comments would significantly improve its maintainability and provide valuable context for future developers. I am unable to approve this pull request, and recommend that others review and approve this code before merging. At a minimum, the comments should be added before merging.