Skip to content

Pin standalone to yao-pkg/[email protected] #8616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

Pin standalone to yao-pkg/[email protected] #8616

merged 3 commits into from
May 27, 2025

Conversation

joehan
Copy link
Contributor

@joehan joehan commented May 16, 2025

Description

yao-pkg/[email protected] is breaking the Firepit build job because it points at node binaries that were not uploaded to Github (see yao-pkg/pkg-fetch#82). Until that is fixed, pin to the last known good version.

Scenarios Tested

Used this when repairing the issues from last release, and it worked correctly.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.08%. Comparing base (2263d68) to head (cbce677).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8616      +/-   ##
==========================================
+ Coverage   51.04%   51.08%   +0.03%     
==========================================
  Files         431      431              
  Lines       30986    31001      +15     
  Branches     6367     6368       +1     
==========================================
+ Hits        15818    15837      +19     
+ Misses      13752    13749       -3     
+ Partials     1416     1415       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@robertsLando
Copy link

I'm going to release a new patch for pkg to fix the issue

Copy link
Contributor

@aalej aalej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me! Tested running the build script locally.

Though it looks like a patch was released in 6.5.1, might also be a good option to pin to that version.

@joehan joehan merged commit e4b79ea into master May 27, 2025
26 of 28 checks passed
@joehan joehan deleted the jh-pin-pkg branch May 27, 2025 16:56
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions May 27, 2025
@joehan
Copy link
Contributor Author

joehan commented May 27, 2025

I'm going to release a new patch for pkg to fix the issue

Thanks! Will be on the look out for that. Merged this for now to keep us in a releasable state, but planning to go back to the latest version shortly

@robertsLando
Copy link

The patch is out already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants