Skip to content

Save file before execution #8601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 15, 2025
Merged

Save file before execution #8601

merged 5 commits into from
May 15, 2025

Conversation

hlshen
Copy link
Contributor

@hlshen hlshen commented May 15, 2025

Save the active text editor before running an execution.

Tested locally.

@hlshen hlshen enabled auto-merge (squash) May 15, 2025 23:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.04%. Comparing base (2263d68) to head (7a2a0b9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8601   +/-   ##
=======================================
  Coverage   51.04%   51.04%           
=======================================
  Files         431      431           
  Lines       30986    30986           
  Branches     6367     6367           
=======================================
  Hits        15818    15818           
  Misses      13752    13752           
  Partials     1416     1416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hlshen hlshen merged commit bdf399f into master May 15, 2025
50 checks passed
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions May 15, 2025
@hlshen hlshen deleted the hlshen/save-on-run branch May 16, 2025 05:22
kjelko pushed a commit that referenced this pull request May 16, 2025
* save file before execution

* Update firebase-vscode/src/data-connect/execution/execution.ts

Co-authored-by: Yuchen Shi <[email protected]>

---------

Co-authored-by: Yuchen Shi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants