[FDC] Generate schema during init dataconnect flow #8596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maneesht
reviewed
May 15, 2025
| @@ -111,7 +112,7 @@ export async function askQuestions(setup: Setup): Promise<void> { | |||
| })); | |||
| if (shouldConfigureBackend) { | |||
| // TODO: Prompt for app idea and use GiF backend to generate them. | |||
maneesht
reviewed
May 15, 2025
| * @param text the generated response from the service. | ||
| * @return the code block from the generated response. | ||
| */ | ||
| export function extractCodeBlock(text: string): string { |
There was a problem hiding this comment.
We should probably get a test for this if possible
There was a problem hiding this comment.
Sure, just vaib coded a test case for it.
joehan
requested changes
May 15, 2025
github-project-automation
bot
moved this to Changes Requested [PR]
in [Cloud] Extensions + Functions
Co-authored-by: joehan <[email protected]>
Co-authored-by: joehan <[email protected]>
|
Addressed all feedbacks~ |
joehan
approved these changes
May 15, 2025
github-project-automation
bot
moved this from Changes Requested [PR]
to Approved [PR]
in [Cloud] Extensions + Functions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8596 +/- ##
=======================================
Coverage 51.04% 51.05%
=======================================
Files 431 432 +1
Lines 30986 31018 +32
Branches 6367 6370 +3
=======================================
+ Hits 15818 15835 +17
- Misses 13752 13766 +14
- Partials 1416 1417 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joehan
requested changes
May 16, 2025
github-project-automation
bot
moved this from Approved [PR]
to Changes Requested [PR]
in [Cloud] Extensions + Functions
|
Double checked with Kara and Thevi. Since we print out the terms of service disclosure, this change should be good to go. MPC server integration is blocked on more review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ToS note as well