Pass along FIREBASE_PYTHON_HOST_EXECUTABLE for leveldb.cmake #9847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use leveldb.cmake uses it
Coverage Report 1Affected Products
Test Logs |
wu-hui
approved these changes
May 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where setting up the leveldb build in cmake would sometimes use an incorrect python interpreter when patching its source code. This happened because the leveldb build is invoked in a child cmake process, to which the cache variables are explicitly passed in via cmake's
-Dcommand-line argument.The
FIREBASE_PYTHON_HOST_EXECUTABLEcache variable was introduced in #9662, and the leveldb build was modified in #9596 to use it; however, it must have gone unnoticed that it was ignoring theFIREBASE_PYTHON_HOST_EXECUTABLEcache variable. This PR fixes this.Here is where this bug was discovered: firebase/firebase-cpp-sdk#967 (comment)