Fix memory leak from ASAN checks (#9750)

Author: wu-hui

Firestore/core/src/model/value_util.cc

@@ -53,6 +53,26 @@ const char* kRawMaxValueFieldValue = "__max__";
 pb_bytes_array_s* kMaxValueFieldValue =
     nanopb::MakeBytesArray(kRawMaxValueFieldValue);
 
+/** The special map field value entry of a maximum proto value. */
+google_firestore_v1_MapValue_FieldsEntry kMaxValueFieldEntry = {
+    .key = kMaxValueFieldKey,
+    .value = {
+        .which_value_type = google_firestore_v1_Value_string_value_tag,
+        .string_value = const_cast<pb_bytes_array_t*>(kMaxValueFieldValue)}};
+
+/** The special map value of a maximum proto value. */
+_google_firestore_v1_MapValue kMaxValueMapValue = {
+    .fields_count = 1, .fields = &kMaxValueFieldEntry};
+
+/**
+ * A maximum value that is larger than any other Firestore values. Underlying it
+ * is a map value with a special map field that SDK user cannot possibly
+ * construct.
+ */
+google_firestore_v1_Value kMaxValue = {
+    .which_value_type = google_firestore_v1_Value_map_value_tag,
+    .map_value = kMaxValueMapValue};
+
 }  // namespace
 
 using nanopb::Message;
@@ -684,16 +704,7 @@ bool IsMinValue(const google_firestore_v1_Value& value) {
 }
 
 google_firestore_v1_Value MaxValue() {
-  google_firestore_v1_Value max_value;
-  max_value.which_value_type = google_firestore_v1_Value_map_value_tag;
-  max_value.map_value.fields_count = 1;
-  max_value.map_value.fields =
-      nanopb::MakeArray<google_firestore_v1_MapValue_FieldsEntry>(1);
-  max_value.map_value.fields[0].key = kMaxValueFieldKey;
-  max_value.map_value.fields[0].value.which_value_type =
-      google_firestore_v1_Value_string_value_tag;
-  max_value.map_value.fields[0].value.string_value = kMaxValueFieldValue;
-  return max_value;
+  return kMaxValue;
 }
 
 bool IsMaxValue(const google_firestore_v1_Value& value) {

Firestore/core/test/unit/local/local_serializer_test.cc

@@ -324,14 +324,13 @@ class LocalSerializerTest : public ::testing::Test {
 
   void ExpectSerializationRoundTrip(const NamedQuery& named_query,
                                     const ::firestore::NamedQuery& proto) {
-    ByteString bytes = EncodeNamedQuery(&serializer, named_query);
+    ByteString bytes = EncodeNamedQuery(named_query);
     auto actual = ProtobufParse<::firestore::NamedQuery>(bytes);
     EXPECT_TRUE(msg_diff.Compare(proto, actual)) << message_differences;
   }
 
-  ByteString EncodeNamedQuery(local::LocalSerializer* serializer,
-                              const NamedQuery& named_query) {
-    return MakeByteString(serializer->EncodeNamedQuery(named_query));
+  ByteString EncodeNamedQuery(const NamedQuery& named_query) {
+    return MakeByteString(serializer.EncodeNamedQuery(named_query));
   }
 
   void ExpectDeserializationRoundTrip(const NamedQuery& named_query,
@@ -370,120 +369,6 @@ class LocalSerializerTest : public ::testing::Test {
   MessageDifferencer msg_diff;
 };
 
-// TODO(b/174608374): Remove these tests once we perform a schema migration.
-TEST_F(LocalSerializerTest, SetMutationAndTransformMutationAreSquashed) {
-  ::firestore::client::WriteBatch batch_proto{};
-  batch_proto.set_batch_id(42);
-  *batch_proto.add_writes() = SetProto();
-  *batch_proto.add_writes() = LegacyTransformProto();
-  *batch_proto.mutable_local_write_time() = WriteTimeProto();
-
-  ByteString bytes = ProtobufSerialize(batch_proto);
-  StringReader reader(bytes);
-  auto message = Message<firestore_client_WriteBatch>::TryParse(&reader);
-  MutationBatch decoded = serializer.DecodeMutationBatch(&reader, *message);
-  ASSERT_EQ(1, decoded.mutations().size());
-  ASSERT_EQ(Mutation::Type::Set, decoded.mutations()[0].type());
-
-  Message<google_firestore_v1_Write> encoded{
-      remote_serializer.EncodeMutation(decoded.mutations()[0])};
-  ExpectSet(*encoded);
-  ExpectUpdateTransform(*encoded);
-}
-
-// TODO(b/174608374): Remove these tests once we perform a schema migration.
-TEST_F(LocalSerializerTest, PatchMutationAndTransformMutationAreSquashed) {
-  ::firestore::client::WriteBatch batch_proto{};
-  batch_proto.set_batch_id(42);
-  *batch_proto.add_writes() = PatchProto();
-  *batch_proto.add_writes() = LegacyTransformProto();
-  *batch_proto.mutable_local_write_time() = WriteTimeProto();
-
-  ByteString bytes = ProtobufSerialize(batch_proto);
-  StringReader reader(bytes);
-  auto message = Message<firestore_client_WriteBatch>::TryParse(&reader);
-  MutationBatch decoded = serializer.DecodeMutationBatch(&reader, *message);
-  ASSERT_EQ(1, decoded.mutations().size());
-  ASSERT_EQ(Mutation::Type::Patch, decoded.mutations()[0].type());
-
-  Message<google_firestore_v1_Write> encoded{
-      remote_serializer.EncodeMutation(decoded.mutations()[0])};
-  ExpectPatch(*encoded);
-  ExpectUpdateTransform(*encoded);
-}
-
-// TODO(b/174608374): Remove these tests once we perform a schema migration.
-TEST_F(LocalSerializerTest, TransformAndTransformThrowError) {
-  ::firestore::client::WriteBatch batch_proto{};
-  batch_proto.set_batch_id(42);
-  *batch_proto.add_writes() = LegacyTransformProto();
-  *batch_proto.add_writes() = LegacyTransformProto();
-  *batch_proto.mutable_local_write_time() = WriteTimeProto();
-
-  ByteString bytes = ProtobufSerialize(batch_proto);
-  StringReader reader(bytes);
-  auto message = Message<firestore_client_WriteBatch>::TryParse(&reader);
-  EXPECT_ANY_THROW(serializer.DecodeMutationBatch(&reader, *message));
-}
-
-// TODO(b/174608374): Remove these tests once we perform a schema migration.
-TEST_F(LocalSerializerTest, DeleteAndTransformThrowError) {
-  ::firestore::client::WriteBatch batch_proto{};
-  batch_proto.set_batch_id(42);
-  *batch_proto.add_writes() = DeleteProto();
-  *batch_proto.add_writes() = LegacyTransformProto();
-  *batch_proto.mutable_local_write_time() = WriteTimeProto();
-
-  ByteString bytes = ProtobufSerialize(batch_proto);
-  StringReader reader(bytes);
-  auto message = Message<firestore_client_WriteBatch>::TryParse(&reader);
-  EXPECT_ANY_THROW(serializer.DecodeMutationBatch(&reader, *message));
-}
-
-// TODO(b/174608374): Remove these tests once we perform a schema migration.
-TEST_F(LocalSerializerTest, MultipleMutationsAreSquashed) {
-  ::firestore::client::WriteBatch batch_proto{};
-  batch_proto.set_batch_id(42);
-  *batch_proto.add_writes() = SetProto();
-  *batch_proto.add_writes() = SetProto();
-  *batch_proto.add_writes() = LegacyTransformProto();
-  *batch_proto.add_writes() = DeleteProto();
-  *batch_proto.add_writes() = PatchProto();
-  *batch_proto.add_writes() = LegacyTransformProto();
-  *batch_proto.add_writes() = PatchProto();
-  *batch_proto.mutable_local_write_time() = WriteTimeProto();
-
-  ByteString bytes = ProtobufSerialize(batch_proto);
-  StringReader reader(bytes);
-  auto message = Message<firestore_client_WriteBatch>::TryParse(&reader);
-  MutationBatch decoded = serializer.DecodeMutationBatch(&reader, *message);
-  ASSERT_EQ(5, decoded.mutations().size());
-
-  Message<google_firestore_v1_Write> encoded{
-      remote_serializer.EncodeMutation(decoded.mutations()[0])};
-  ExpectSet(*encoded);
-  ExpectNoUpdateTransform(*encoded);
-
-  encoded =
-      MakeMessage(remote_serializer.EncodeMutation(decoded.mutations()[1]));
-  ExpectSet(*encoded);
-  ExpectUpdateTransform(*encoded);
-
-  encoded =
-      MakeMessage(remote_serializer.EncodeMutation(decoded.mutations()[2]));
-  ExpectDelete(*encoded);
-
-  encoded =
-      MakeMessage(remote_serializer.EncodeMutation(decoded.mutations()[3]));
-  ExpectPatch(*encoded);
-  ExpectUpdateTransform(*encoded);
-
-  encoded =
-      MakeMessage(remote_serializer.EncodeMutation(decoded.mutations()[4]));
-  ExpectPatch(*encoded);
-  ExpectNoUpdateTransform(*encoded);
-}
-
 TEST_F(LocalSerializerTest, EncodesMutationBatch) {
   Mutation base =
       PatchMutation(Key("docs/1"), WrapObject("a", "b"), FieldMask{Field("a")},