[apidocs] Improve file detection and updates toc.yaml #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
approved these changes
Aug 10, 2021
egilmorez
approved these changes
Aug 11, 2021
| @@ -198,7 +198,10 @@ async function checkForMissingFilesAndFixFilenameCase(tocText) { | |||
| const filenames = tocText | |||
| .split('\n') | |||
| .filter((line) => line.includes('path:')) | |||
| .map((line) => line.split(devsitePath)[1].replace(/#.*$/, '')); | |||
| .map((line) => { | |||
There was a problem hiding this comment.
Wow I would have had no idea how to refactor that.
Do we need to update the value for 'const devsitePath' as well? Or does this basically override that and extrapolate it from the toc.yaml file (which makes a lot of sense, since that is in a versioned directory that can be updated as we go)?
There was a problem hiding this comment.
The only other thing devsitePath feeds is _toc_autogenerated.yaml which I'm not sure if you use. That being said, I now fork devsitePath based on version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.