Skip to content

Fixes an emulator issue where snapshot.ref could not point to multiple databases #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 30, 2023
Merged

Fixes an emulator issue where snapshot.ref could not point to multiple databases #1339

merged 5 commits into from
Jan 30, 2023

Conversation

colerogers
Copy link
Contributor

@colerogers colerogers commented Jan 18, 2023 •
edited
Loading

Per @fredzqm, we don't need the first condition of the snapshot constructor to figure out the instance. Fixes firebase/firebase-tools#3961

@colerogers colerogers requested review from taeold and fredzqm January 18, 2023 15:19
@colerogers colerogers merged commit bcf41c6 into master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredzqm fredzqm fredzqm approved these changes

@taeold taeold taeold approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

snapshot.ref with multiple realtime databases points to the wrong one with Emulators
3 participants
@colerogers @fredzqm @taeold