Skip to content

Mark vpc connector as accepting string param type #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2022
Merged

Mark vpc connector as accepting string param type #1329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32d96fd
mark vpc connector as accepting string param type
Berlioz Dec 20, 2022
cb24a94
add changelog
Berlioz Dec 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Allow Functions to specify vpcConnector as a string parameter (#1329)
2 changes: 1 addition & 1 deletion src/v1/function-configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ export interface RuntimeOptions {
/**
* Connect cloud function to specified VPC connector.
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down
2 changes: 1 addition & 1 deletion src/v2/options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export interface GlobalOptions {
/**
* Connect cloud function to specified VPC connector.
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/alerts/alerts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export interface FirebaseAlertOptions extends options.EventHandlerOptions {
* Connect cloud function to specified VPC connector.
* A value of null removes the VPC connector
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/alerts/appDistribution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export interface AppDistributionOptions extends options.EventHandlerOptions {
/**
* Connect cloud function to specified VPC connector.
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/alerts/crashlytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ export interface CrashlyticsOptions extends options.EventHandlerOptions {
/**
* Connect cloud function to specified VPC connector.
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export interface ReferenceOptions<Ref extends string = string> extends options.E
/**
* Connect cloud function to specified VPC connector.
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/eventarc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ export interface EventarcTriggerOptions extends options.EventHandlerOptions {
/**
* Connect cloud function to specified VPC connector.
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/https.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export interface HttpsOptions extends Omit<GlobalOptions, "region"> {
/**
* Connect cloud function to specified VPC connector.
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/identity.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ export interface BlockingOptions {
/**
* Connect cloud function to specified VPC connector.
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/pubsub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ export interface PubSubOptions extends options.EventHandlerOptions {
/**
* Connect cloud function to specified VPC connector.
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/storage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ export interface StorageOptions extends options.EventHandlerOptions {
/**
* Connect cloud function to specified VPC connector.
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down
2 changes: 1 addition & 1 deletion src/v2/providers/tasks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export interface TaskQueueOptions extends options.EventHandlerOptions {
/**
* Connect cloud function to specified VPC connector.
*/
vpcConnector?: string | ResetValue;
vpcConnector?: string | Expression<string> | ResetValue;

/**
* Egress settings for VPC connector.
Expand Down