Support for writing params of type List during discovery #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
reviewed
Nov 1, 2022
| expect(p1.equals(p2).value()).to.be.false; | ||
| expect(p1.notEquals(p2).value()).to.be.true; | ||
|
|
||
| expect(() => p1.greaterThan(p1).value()).to.throw; |
There was a problem hiding this comment.
This is why I wish we had done operators in the type system with strong types for each expression type =/
src/params/types.ts
Outdated
| @@ -159,6 +164,7 @@ type ParamValueType = "string" | "list" | "boolean" | "int" | "float" | "secret" | |||
| type ParamInput<T> = | |||
| | { text: TextInput<T> } | |||
| | { select: SelectInput<T> } | |||
| | { selectList: SelectListInput } | |||
There was a problem hiding this comment.
I thought this was called MultiSelect in the spec since that name has been common since the days of jQuery.
taeold
reviewed
Nov 9, 2022
| }); | ||
|
|
||
| it("falls back on the javascript zero values in case a list param's is unparsable as string[]", () => { | ||
| const notAllStrings = params.defineList("BAD_LIST"); |
There was a problem hiding this comment.
no action required - but i can see this being pretty frustrating if we silent fall back to an empty list if the list isn't made up of all string elements :/.
I don't think we expect this to happen in real life since environment variable will almost always be strings anyway?
taeold
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.