-
Notifications
You must be signed in to change notification settings - Fork 211
Add v2 Remote Config Triggers #1216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
13f66d6
to
9eb8be5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving the doc comments. Do you want to mark these triggers as @Alpha until we have samples/docs/CLI support merged and released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing - do you want to add integration test target for this (in this PR or later in another PR).
@taeold - added the |
Adds remote config triggers to CF3v2