Skip to content

Add v2 Remote Config Triggers #1216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 9, 2022
Merged

Conversation

colerogers
Copy link
Contributor

@colerogers colerogers commented Aug 31, 2022

Adds remote config triggers to CF3v2

import { onConfigUpdated } from 'firebase-functions/v2/remoteConfig';

export const fn = onConfigUpdated((event) => { console.log("hello world"); });

@colerogers colerogers force-pushed the colerogers.remote-config branch from 13f66d6 to 9eb8be5 Compare September 2, 2022 18:23
@colerogers colerogers changed the base branch from master to launch.next September 2, 2022 19:13
@colerogers colerogers marked this pull request as ready for review September 8, 2022 16:05
Copy link
Contributor

@TheIronDev TheIronDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving the doc comments. Do you want to mark these triggers as @Alpha until we have samples/docs/CLI support merged and released?

Copy link
Contributor

@taeold taeold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing - do you want to add integration test target for this (in this PR or later in another PR).

@colerogers
Copy link
Contributor Author

@taeold - added the @alpha tags & since this change requires CLI changes to be released, I'll follow up with a int test in another PR

@colerogers colerogers merged commit a54cd0b into launch.next Sep 9, 2022
@taeold taeold added this to the v4 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants