Skip to content

More ESLint Migration #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2022
Merged

More ESLint Migration #1197

merged 2 commits into from
Aug 23, 2022

Conversation

taeold
Copy link
Contributor

@taeold taeold commented Aug 23, 2022

Turns out I missed most of the files for migration from prettier to eslint in #1194 due to poorly configured .eslintignore - it ignored all files under src/v1 and src/v2!

Correctly configure eslint and run npm run format. Again, I had to manually fixup issues like:

  1. Remove empty function definition (prefer ()=>undefined over ()=>{})
  2. Remove unused arguments from function definitions

@taeold
Copy link
Contributor Author

taeold commented Aug 23, 2022

Again, I'm going to merge this PR without waiting for a review. I don't expect a human to be able to review this PR. Instead, we will rely on integration tests and bugbash to help surface any accidental regression.

@taeold taeold merged commit c303eab into launch.next Aug 23, 2022
@taeold taeold deleted the dl-mo-eslint branch August 23, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant