Add TQ support #1002
Merged
Add TQ support #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
commented
Nov 5, 2021
| @@ -172,35 +220,6 @@ function checkAppCheckContext( | |||
| expect(context.instanceIdToken).to.be.undefined; | |||
| } | |||
|
|
|||
| function checkAuthRequest( | |||
There was a problem hiding this comment.
Deleted these because a CallableRequest is a CallableContext. Made the overload explicit in the method I kept anyway.
| @@ -648,6 +667,187 @@ describe('onCallHandler', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('onEnqueueHandler', () => { | |||
There was a problem hiding this comment.
copy + paste + tweak from onCallHandler
| @@ -201,6 +208,106 @@ describe('#onCall', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('#onEnqueue', () => { | |||
There was a problem hiding this comment.
copy + paste + tweak from onCall
| @@ -366,3 +366,139 @@ describe('onCall', () => { | |||
| https.onCall((request: https.CallableRequest) => `Hello, ${request.data}`); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('onTaskEnqueue', () => { | |||
There was a problem hiding this comment.
copy + paste + tweak from onCall
taeold
approved these changes
Nov 5, 2021
src/common/providers/https.ts
Outdated
| @@ -169,6 +169,56 @@ export interface CallableRequest<T = any> { | |||
| rawRequest: Request; | |||
| } | |||
|
|
|||
| /** How a task should be retried in the event of a non-2xx return. */ | |||
| export interface TaskRetryConfig { | |||
| // If left unspecified, will default to 5 | |||
There was a problem hiding this comment.
Q: Should be leave this comment out? Wondering if this comment is better left out since it's the responsibility of the CLI/Cloud Task Queue to set the defaults if missing.
There was a problem hiding this comment.
I think the bug is that these aren't customer docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds preview support for TQ.
V1 APIs should have an
@hiddenannotation. V2 APIs area already hidden behind obscure imports.I'm having some trouble with code complete not prompting unless I start typing. If anyone knows what the issue might be there I'd love to know.