Add ingress settings support

[marcelgoya]

The runWidth function is missing the possibility to set the network ingress flag as compared to the official google cloud sdk:

https://cloud.google.com/functions/docs/networking/network-settings#gcloud

INGRESS_SETTINGS is one of the supported values for ingress settings. The possible values are:

• all
• internal-only
• internal-and-gclb: allows internal traffic as well as traffic sent to a public IP exposed by Google Cloud Load Balancer (GCLB). Blocks traffic sent to cloudfunctions.net or any custom domain set up through Cloud Functions. Prevents users from circumventing any access controls (Cloud Armor, IAP) they set up through GCLB.

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[joehan]

Hey @marcelgoya, this sounds like it would be a great feature to add. If you are willing to make a PR to add this, I can bring it through our internal API review process.

[marcelgoya]

Hi @joehan, I thought of it more as keeping both product libraries in sync in regards to feature parity as the firebase lib uses the google lib under the hood. I didn't know that this lib is community maintained :)

[marcelgoya]

Alright, that's done

[joehan]

Thanks a ton @marcelgoya - and to clarify, we do maintain this library but we always appreciate community contributions :). Since this is an API change, I do need to get it reviewed before it is released, but I don't foresee anyone being against this. If all goes well, this should be released in 1 to 2 weeks.

[marcelgoya]

@joehan My pleasure, it was only a 5 minute change anyway :) Awesome, thanks for your help.

[joehan]

This was approved! I'll merge your PR and get a new version released later today. Thanks again for the contribution!

[takaaa220]

Is this feature already available?
I have deployed this function so that it cannot be accessed from the outside.
(no compilation error)

// index.ts
export const helloWorld = functions
 .region("asia-northeast1")
 .runWith({
   ingressSettings: "ALLOW_INTERNAL_AND_GCLB",
 })
 .https.onRequest((_, res) => {
   res.send("Hello from Firebase!");
 });

But, I can access this function as follows:

$ curl -X POST https://asia-northeast1-myproject-xxxxx.cloudfunctions.net/helloWorld
> Hello from Firebase!

My version info

firebase-functions: 3.13.0
firebase-tools: 8.19.0
node: 10.22.1

[CarltonK]

@joehan Was the PR merged? Are the ingress settings live?

[richtu4n]

It seems this has been merged but not yet released. Is there any timeline on when the next release will be?

[trevorhreed]

It looks like this was released in v3.12.0.