Update iOS dependencies - Tue May 31 2022 #977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![firebase-workflow-trigger[bot]](https://avatars.githubusercontent.com/in/105283?s=60&v=4){kind=small}
### iOS - Firebase/Analytics → 9.1.0 - Firebase/Auth → 9.1.0 - Firebase/Core → 9.1.0 - Firebase/Crashlytics → 9.1.0 - Firebase/Database → 9.1.0 - Firebase/DynamicLinks → 9.1.0 - Firebase/Firestore → 9.1.0 - Firebase/Functions → 9.1.0 - Firebase/Installations → 9.1.0 - Firebase/Messaging → 9.1.0 - Firebase/RemoteConfig → 9.1.0 - Firebase/Storage → 9.1.0 > Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/2416912624).
firebase-workflow-trigger
bot
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @cynthiajoan on commit 2b81a0e
Add flaky tests to go/fpl-cpp-flake-tracker |
DellaBitta
approved these changes
May 31, 2022
This fixes the following build error:
```
The following tests FAILED:
1 - charclass_test (Not Run)
2 - compile_test (Not Run)
3 - filtered_re2_test (Not Run)
4 - mimics_pcre_test (Not Run)
...
```
e.g. https://github.com/firebase/firebase-cpp-sdk/runs/6676610733
This is caused by the addition of re2 to the firebase-ios-sdk in firebase/firebase-ios-sdk#9488.
I'm not sure _why_ these tests can't be found; but they're superfluous anyways. So just disable them.
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: failed
firebase-workflow-trigger
bot
removed
the
tests: in-progress
…ion. This ports firebase/firebase-ios-sdk#9868 to the firebase-cpp-sdk repository by patching the firebase-ios-sdk when it is cloned. Once the dependency on the firebase-ios-sdk is updated to a version that already includes firebase/firebase-ios-sdk#9868 then this commit should be reverted.
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
dconeybe
added
the
tests-requested: quick
github-actions
bot
added
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
|
FYI: There is a typo in the commit message for 895126f: The PR link should be firebase/firebase-ios-sdk#9851 |
DellaBitta
approved these changes
Jun 1, 2022
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS