Skip to content

Fix storage content-type on desktop, and add test. #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 25, 2022

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Apr 22, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Storage desktop: When uploading a file with custom metadata, if the metadata specifies a content-type, use that as the content-type for the HTTP request.

This should fix firebase/quickstart-unity#1107, which is failing because of the Content-Type of the HTTP upload.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Add upload of image file to integration test. (In the future, this could be extended to support image resize, etc.)


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@jonsimantov jonsimantov requested a review from AlmostMatt April 22, 2022 18:27
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 22, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 22, 2022
@github-actions
Copy link

github-actions bot commented Apr 22, 2022

Integration test with FLAKINESS (succeeded after retry)

Requested by @jonsimantov on commit 0a0c4fc
Last updated: Mon Apr 25 18:34 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Apr 22, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 22, 2022
@jonsimantov
Copy link
Contributor Author

Test failure may not be related to this, but I'll investigate.

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 22, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Apr 22, 2022
@jonsimantov
Copy link
Contributor Author

Test failure may not be related to this, but I'll investigate.

Was related - caused by multithreaded access. Fixed.

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 22, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 22, 2022
Copy link
Contributor

@AlmostMatt AlmostMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple minor comments/questions.

@jonsimantov jonsimantov requested a review from AlmostMatt April 25, 2022 20:55
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Apr 25, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Apr 25, 2022
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 25, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 25, 2022
@jonsimantov jonsimantov merged commit 0a0c4fc into main Apr 25, 2022
@jonsimantov jonsimantov deleted the bugfix/storage_desktop_content_type branch April 25, 2022 22:23
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Apr 25, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 26, 2022
@firebase firebase locked and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to use the Firebase Resize Image Extension when uploading from the Unity SDK
2 participants