-
Notifications
You must be signed in to change notification settings - Fork 123
Fix storage content-type on desktop, and add test. #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Integration test with FLAKINESS (succeeded after retry)Requested by @jonsimantov on commit 0a0c4fc
Add flaky tests to go/fpl-cpp-flake-tracker |
Test failure may not be related to this, but I'll investigate. |
Was related - caused by multithreaded access. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple minor comments/questions.
Description
Storage desktop: When uploading a file with custom metadata, if the metadata specifies a content-type, use that as the content-type for the HTTP request.
This should fix firebase/quickstart-unity#1107, which is failing because of the Content-Type of the HTTP upload.
Testing
Add upload of image file to integration test. (In the future, this could be extended to support image resize, etc.)
Type of Change
Place an
x
the applicable box:Notes
Release Notes
section ofrelease_build_files/readme.md
.