-
Notifications
You must be signed in to change notification settings - Fork 122
Fix app build for Android against prebuilt version #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
❌ Integration test FAILEDRequested by @jonsimantov on commit refs/pull/736/merge
Add flaky tests to go/fpl-cpp-flake-tracker |
@googlebot I signed it! |
@jonsimantov Are you sure the tests failed because of my commit? |
Looks like unrelated issues, I'll remove the "failed" flag. |
Change looks good, could you please add a PR description and then I'll approve it. Thanks for your contribution! |
@jonsimantov Okay, done. |
Description
Fix app build for
Android
against prebuilt Firebase C++ SDK.Android NDK 21 says:
fatal error: 'app/src/include/firebase/future.h' file not found
Testing
Building was tested on my local computer.
Type of Change
Notes
Look at the files in
app/src/include/firebase/
directory.File doesn't contain
app/src/include/
prefix inside#include
paths.Also removing the prefix
app/src/include/
from line25
ofapp/src/include/google_play_services/availability.h
has solved my build problem.