Skip to content

Fix app build for Android against prebuilt version #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Fix app build for Android against prebuilt version #736

merged 1 commit into from
Nov 8, 2021

Conversation

borissoft
Copy link
Contributor

@borissoft borissoft commented Nov 5, 2021

Description

Fix app build for Android against prebuilt Firebase C++ SDK.

Android NDK 21 says: fatal error: 'app/src/include/firebase/future.h' file not found

Testing

Building was tested on my local computer.

Type of Change

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

Look at the files in app/src/include/firebase/ directory.
File doesn't contain app/src/include/ prefix inside #include paths.
Also removing the prefix app/src/include/ from line 25 of app/src/include/google_play_services/availability.h has solved my build problem.

@google-cla
Copy link

google-cla bot commented Nov 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 5, 2021
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Nov 5, 2021
@github-actions
Copy link

github-actions bot commented Nov 5, 2021

❌  Integration test FAILED

Requested by @jonsimantov on commit refs/pull/736/merge
Last updated: Fri Nov 5 14:30 PDT 2021
View integration test log & download artifacts

Failures Configs
database [BUILD] [ERROR] [MacOS] [openssl]
firestore [TEST] [ERROR] [Android] [windows] [android_target]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 5, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 5, 2021
@borissoft
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 5, 2021
@borissoft
Copy link
Contributor Author

borissoft commented Nov 5, 2021

@jonsimantov Are you sure the tests failed because of my commit?

@jonsimantov
Copy link
Contributor

@jonsimantov Are you sure the tests failed because of my commit?

Looks like unrelated issues, I'll remove the "failed" flag.

@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Nov 5, 2021
@jonsimantov jonsimantov self-requested a review November 5, 2021 22:40
@jonsimantov
Copy link
Contributor

Change looks good, could you please add a PR description and then I'll approve it.

Thanks for your contribution!

@jonsimantov jonsimantov added the skip-release-notes Skip release notes check label Nov 5, 2021
@borissoft
Copy link
Contributor Author

@jonsimantov Okay, done.

@jonsimantov jonsimantov merged commit ae8a3f2 into firebase:main Nov 8, 2021
@firebase firebase locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes skip-release-notes Skip release notes check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants