Replace ThrowInvalidArgument with SimpleThrowInvalidArgument to fix iOS absl linker error in Unity SDK

[dconeybe]

This a follow-up fix to #616 which additionally replaces ThrowInvalidArgument with SimpleThrowInvalidArgument to avoid absl-related linker errors in the Unity SDK for iOS.

The "style" of the changes made in this PR were based on those made in other files, such as:

firebase-cpp-sdk/firestore/src/main/query_main.cc

Lines 196 to 206 in cebf363

	// TODO(b/147444199): use string formatting.
	// ThrowInvalidArgument(
	// "Invalid query. You are trying to start or end a query using a "
	// "document for which the field '%s' (used as the order by) does not
	// " "exist.", field_path.CanonicalString());
	auto message = std::string(
	"Invalid query. You are trying to start or end a "
	"query using a document for which the field '") +
	field_path.CanonicalString() +
	"' (used as the order by) does not exist.";
	SimpleThrowInvalidArgument(message);

Googlers can see cl/289114361 for the introduction of SimpleThrowInvalidArgument for context.

[github-actions]

✅  Integration test succeeded!

Requested by @dconeybe on commit 6d3ec1d
Last updated: Wed Aug 25 10:22 PDT 2021
View integration test log & download artifacts

[ehsannas]

Do we expect the absl linker errors to be resolved anytime soon? If not, should we consider removing ThrowInvalidArgument? It may inadvertently be used again and break releases.

[dconeybe]

Do we expect the absl linker errors to be resolved anytime soon? If not, should we consider removing ThrowInvalidArgument? It may inadvertently be used again and break releases.

Yes. It will be solved once the Unity SDK is built from GitHub. See cl/289114361 for more explanation.

Also, ThrowInvalidArgument is in the iOS SDK (not this SDK) so deleting it isn't really a great option since it's used harmlessly throughout the iOS SDK.

https://github.com/firebase/firebase-ios-sdk/blob/6751623a443a01ce6070f87b96c1bc56a86dc56d/Firestore/core/src/util/exception.h#L91-L96

[ehsannas]

Sounds good, Thanks!

[var-const]

Thanks!