-
Notifications
You must be signed in to change notification settings - Fork 123
Prevent Windows GHA CI disk exhausation #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Integration test succeeded!Requested by @DellaBitta on commit d7b7a13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this! One minor note but LGTM otherwise.
set -x | ||
mkdir -p ${{env.GCS_UPLOAD_DIR}}/scripts/gha/integration_testing | ||
mkdir -p ${{env.GCS_UPLOAD_DIR}}/scripts/gha-encrypted | ||
tar -chf ${{env.GCS_UPLOAD_DIR}}/ta.tar ta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for readability, could you put a comment here what the "ta" directory is? Others are easy to follow.
Just a note, the boringssl change (download tarball -> checkout specific tag in repo) increased the boringssl source code directory size from 100M to 280M. |
Would checking out with --depth 1 help this? |
I'm going to try out some new git cleanup code that I've found to see if I can reduce the size of the checkout, but I'd like to merge this for now so that we can effectively use integration tests moving forward and I can roll back this change if it's not necessary for now. |
Windows BoringSSL builds are now larger due to #454. The checkout & build partition (D:) hits capacity when attempting to install the Google Cloud SDK, which is what we use to upload the final integraion_test build artifacts to storage.
This change moves the arhives destined for GCS to the C: drive, then installs the Cloud SDK after they're off of D:. The migration of the integration tests only occurs on Windows, for now.
Some notes: