Skip to content

cl/361880889: Uncomment Firestore test RestartFirestoreLeadsToNewInstance for Android now that auth is a soft dependency #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2021
Merged

cl/361880889: Uncomment Firestore test RestartFirestoreLeadsToNewInstance for Android now that auth is a soft dependency #334

merged 2 commits into from
Apr 9, 2021

Conversation

dconeybe
Copy link
Contributor

This is a port of cl/361880889:

Uncomment Firestore test RestartFirestoreLeadsToNewInstance for Android now that auth is a soft dependency

@google-cla google-cla bot added the cla: yes label Mar 18, 2021
@jonsimantov
Copy link
Contributor

jonsimantov commented Mar 21, 2021 •
edited
Loading

These tests are actually moving out of this directory into firestore/integration_test_internal/src, could you merge main into this branch and make the change there?

We'll be moving back unit tests there eventually, but integration tests will stay in that new location.

(also you can ignore the integration test failure you see reported in the comments - I'm just testing out the triggers.)

@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 21, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 21, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 21, 2021
@jonsimantov jonsimantov removed the tests: failed This PR's integration tests failed. label Mar 21, 2021
@dconeybe
Copy link
Contributor Author

These tests are actually moving out of this directory into firestore/integration_test_internal/src, could you merge main into this branch and make the change there?

We'll be moving back unit tests there eventually, but integration tests will stay in that new location.

(also you can ignore the integration test failure you see reported in the comments - I'm just testing out the triggers.)

@jonsimantov I'll just hold off merging this PR until this test is moved into its ultimate location in the main branch. It's not an urgent fix.

@jonsimantov
Copy link
Contributor

Test is in its new location now, you can update this PR at your leisure.

@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Apr 9, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Apr 9, 2021
@github-actions
Copy link

github-actions bot commented Apr 9, 2021 •
edited
Loading

✅  Integration test succeeded!

Requested by @dconeybe on commit 384819e
Last updated: Fri Apr 9 09:20:47 PDT 2021
View integration test results

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 9, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 9, 2021
@dconeybe dconeybe enabled auto-merge (squash) April 9, 2021 18:03
@dconeybe dconeybe merged commit 6bd8cf8 into main Apr 9, 2021
@dconeybe dconeybe deleted the dconeybe/PortChangelist361880889 branch April 9, 2021 19:10
@firebase firebase locked and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore cla: yes tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @jonsimantov @schmidt-sebastian