Skip to content

Improve how we deal with artifacts #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Conversation

jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Feb 9, 2021

Several enhancements to reduce transient failures in the packaging step, and just make the workflow cleaner in general:

  1. Delete build artifacts sooner, after they are no longer needed, to reduce the number of artifacts final-merge-packages has to download.
  2. Update to the latest upload-artifact and download-artifact versions, which add better HTTP retry logic.
  3. Switch to a newer version of the delete-artifact action that allows wildcards.

HTTP retry logic. This helps with transient errors in our packaging
workflow, as some of our build artifacts are > 1GB.
@jonsimantov jonsimantov requested a review from vimanyu February 9, 2021 20:26
@google-cla google-cla bot added the cla: yes label Feb 9, 2021
vimanyu
vimanyu previously approved these changes Feb 9, 2021
Copy link
Contributor

@vimanyu vimanyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonsimantov
Copy link
Contributor Author

Realized I could improve this even more, PTAL. Will wait for packaging run to finish before merging.

vimanyu
vimanyu previously approved these changes Feb 9, 2021
@jonsimantov jonsimantov merged commit c1fcd22 into dev Feb 10, 2021
@jonsimantov jonsimantov deleted the feature/artifact-cleanup branch February 10, 2021 23:00
@firebase firebase locked and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants