Bugfix/integration tests mac openssl error #255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DellaBitta
requested changes
Jan 27, 2021
…github.com/firebase/firebase-cpp-sdk into bugfix/integration-tests-mac-openssl-error
jonsimantov
reviewed
Jan 27, 2021
| @@ -264,6 +277,7 @@ def parse_cmdline_args(): | |||
| parser.add_argument('--config', default='Release', help='Release/Debug config') | |||
| parser.add_argument('--target', nargs='+', help='A list of CMake build targets (eg: firebase_app firebase_auth)') | |||
| parser.add_argument('--target_format', default=None, help='(Mac only) whether to output frameworks (default) or libraries.') | |||
| parser.add_argument('--use_openssl', action='store_true', default=None, help='Use openssl for build instead of boringssl') | |||
There was a problem hiding this comment.
What do you thin about just adding an openssl flag to the prereqs script also? (And we can move the Windows openssl setup into there too.)
There was a problem hiding this comment.
Thats a good point but as per our original design, we wanted to keep all architecture specific steps under build_desktop. And if we are using vcpkg, we have to specify the exact architecture to build. Something to discuss in our "various ways to build" meeting but if we want to continue using vcpkg, it makes sense to not have openssl under the prereqs script. For now, I will leave it here but it should be trivial to move this to prereqs if we decide to go that way after the meeting.
DellaBitta
approved these changes
Jan 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_desktop.py.