Skip to content

Update GMA iOS Dependency to 9.7.0 #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 3, 2022
Merged

Update GMA iOS Dependency to 9.7.0 #1040

merged 3 commits into from
Aug 3, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Aug 2, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Update the Google Mobile Ads dependency to 9.7.0.
Fixed an ambiguous selector to in the AdView implementation on iOS.

Testing

Tested manually on simulator and iOS device.
Integration Test CI
Packaged CI -> Integration Test CI

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@DellaBitta DellaBitta changed the title iOS builds and manually tested Update GMA iOS Dependency to 9.7.0 Aug 2, 2022
@DellaBitta DellaBitta marked this pull request as ready for review August 2, 2022 20:51
@AlmostMatt AlmostMatt self-requested a review August 3, 2022 16:44
@DellaBitta DellaBitta merged commit 05890ac into main Aug 3, 2022
@DellaBitta DellaBitta deleted the feature/update_gma_aug_22 branch August 3, 2022 16:49
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Aug 3, 2022
@github-actions
Copy link

github-actions bot commented Aug 3, 2022 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @DellaBitta on commit 05890ac
Last updated: Wed Aug 3 13:07 PDT 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: windows] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 3, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 3, 2022
@firebase firebase locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlmostMatt AlmostMatt AlmostMatt approved these changes

Assignees
No one assigned
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @AlmostMatt