Skip to content

Commit 94b5f05

Browse files
committed
CMakeLists.txt: set(RE2_BUILD_TESTING OFF CACHE BOOL "")
This fixes the following build error: ``` The following tests FAILED: 1 - charclass_test (Not Run) 2 - compile_test (Not Run) 3 - filtered_re2_test (Not Run) 4 - mimics_pcre_test (Not Run) ... ``` e.g. https://github.com/firebase/firebase-cpp-sdk/runs/6676610733 This is caused by the addition of re2 to the firebase-ios-sdk in firebase/firebase-ios-sdk#9488. I'm not sure _why_ these tests can't be found; but they're superfluous anyways. So just disable them.
1 parent 1dfa36f commit 94b5f05

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

CMakeLists.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -214,6 +214,9 @@ endif()
214214
# firebase-ios-sdk since it's not needed and can sometimes fail to build.
215215
set(FIRESTORE_INCLUDE_OBJC OFF CACHE BOOL "Disabled for the CPP SDK")
216216

217+
# Disable re2 build tests
218+
set(RE2_BUILD_TESTING OFF CACHE BOOL "")
219+
217220
if(FIREBASE_CPP_USE_PRIOR_GRADLE_BUILD)
218221
# Quote meta characters in ${CMAKE_CURRENT_LIST_DIR} so we can
219222
# match it in a regex.

0 commit comments

Comments
 (0)