Skip to content

Refactored retry config into _retry.py and added support for exponential backoff and Retry-After header #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 21, 2025

Conversation

jonathanedey
Copy link
Contributor

@jonathanedey jonathanedey commented Apr 14, 2025

Adds more retry logic support

This PR covers:

  • Moving and refactoring HttpxRetryTransport to _retry.py
  • Adding new class HttpxRetry to manage retry state
  • Adding support for setting some retry configurations on HttpxRetryTransport creation
  • Performing exponential backoff before request retries
  • Respecting Retry-After headers from request responses
  • Unit tests for HttpxRetry and HttpxRetryTransport
  • Unit test for handing HTTPX request errors

@jonathanedey jonathanedey added the release:stage Stage a release candidate label Apr 14, 2025
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jonathan! Overall looking good! Added a few comments!


def __init__(
self,
status: int = 10,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to call this max_retries instead?

Copy link
Contributor Author

@jonathanedey jonathanedey May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current state yes because status retries are our only retries we have. This was more of a future proof decision for when we added error retires where we would have total, status and error counters.

Similar to the placeholder comment I think we can use max_retries (and retries_left internally since we decrease this value) and add the other options later.

response, error = None, None

try:
logger.debug('Sending request in _dispatch_with_retry(): %r', request)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to keep these logs in the production code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would want to keep these for future debugging. This would be helpful to catch issues as we iterate. Wdyt?

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@jonathanedey jonathanedey merged commit acf955a into fcm-http2 May 21, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants