Reading project ID from GOOGLE_CLOUD_PROJECT #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornick
requested changes
Jun 29, 2018
firebase_admin/__init__.py
Outdated
| @@ -242,7 +243,7 @@ def _lookup_project_id(cls, credential, options): | |||
| except AttributeError: | |||
| pass | |||
| if not pid: | |||
There was a problem hiding this comment.
hmm. in hindsight pid seems like an unfortunate name for project id. Can we change that?
bjornick
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCLOUD_PROJECTis no longer supported in some managed Google runtimes.GOOGLE_CLOUD_PROJECTis the new recommended environment variable.