Skip to content

Commit 81463e2

Browse files
authored
Upgraded cachecontrol to latest (#378)
* Upgraded cachecontrol to latest * Fixing some failing requests tests
1 parent 22f6761 commit 81463e2

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ pytest-cov >= 2.4.0
44
pytest-localserver >= 0.4.1
55
tox >= 3.6.0
66

7-
cachecontrol >= 0.12.4
7+
cachecontrol >= 0.12.6
88
google-api-core[grpc] >= 1.14.0, < 2.0.0dev; platform.python_implementation != 'PyPy'
99
google-api-python-client >= 1.7.8
1010
google-cloud-firestore >= 1.4.0; platform.python_implementation != 'PyPy'

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
long_description = ('The Firebase Admin Python SDK enables server-side (backend) Python developers '
3838
'to integrate Firebase into their services and applications.')
3939
install_requires = [
40-
'cachecontrol>=0.12.4',
40+
'cachecontrol>=0.12.6',
4141
'google-api-core[grpc] >= 1.14.0, < 2.0.0dev; platform.python_implementation != "PyPy"',
4242
'google-api-python-client >= 1.7.8',
4343
'google-cloud-firestore>=1.4.0; platform.python_implementation != "PyPy"',

tests/test_db.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -819,7 +819,7 @@ def test_http_timeout(self):
819819
assert ref._client.timeout == 60
820820
assert ref.get() == {}
821821
assert len(recorder) == 1
822-
assert recorder[0]._extra_kwargs['timeout'] == 60
822+
assert recorder[0]._extra_kwargs['timeout'] == pytest.approx(60, 0.001)
823823

824824
def test_app_delete(self):
825825
app = firebase_admin.initialize_app(

tests/test_messaging.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1562,7 +1562,7 @@ def test_send(self):
15621562
msg = messaging.Message(topic='foo')
15631563
messaging.send(msg)
15641564
assert len(self.recorder) == 1
1565-
assert self.recorder[0]._extra_kwargs['timeout'] == 4
1565+
assert self.recorder[0]._extra_kwargs['timeout'] == pytest.approx(4, 0.001)
15661566

15671567
def test_topic_management_timeout(self):
15681568
self.fcm_service._client.session.mount(
@@ -1574,7 +1574,7 @@ def test_topic_management_timeout(self):
15741574
)
15751575
messaging.subscribe_to_topic(['1'], 'a')
15761576
assert len(self.recorder) == 1
1577-
assert self.recorder[0]._extra_kwargs['timeout'] == 4
1577+
assert self.recorder[0]._extra_kwargs['timeout'] == pytest.approx(4, 0.001)
15781578

15791579

15801580
class TestSend(object):

0 commit comments

Comments
 (0)