Skip to content

Handle dynamic list of identity providers #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

robapaul88
Copy link
Contributor

This will take care of also hiding buttons from the custom layout when adding them for all possible identity providers, but the actual list is dynamic so some won't be available.

Issue: #1775

@samtstern
Copy link
Contributor

@robapaul88 looks great, thank you for your contribution! Once this is merged it should be available in the 6.3.0-SNAPSHOT builds within about 30 minutes.

@samtstern samtstern merged commit c5185f7 into firebase:version-6.3.0-dev Jun 23, 2020
@robapaul88 robapaul88 deleted the version-6.3.0-dev branch June 23, 2020 13:35
@robapaul88
Copy link
Contributor Author

@samtstern
Copy link
Contributor

@robapaul88 no idea, the build job ran successfully:
https://github.com/firebase/FirebaseUI-Android/runs/799349580?check_suite_focus=true

But looks like it hasn't updated in 90 days!

@samtstern
Copy link
Contributor

Hmm it looks like firebase-ui-common is deploying to artifactory but the others are not ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants