Fix: Fixed issue where some file operations would fail

[hishitetsu]

Resolved / Related Issues

• Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
  Closes Bug: Permanently delete doesn't work all the time #15133

Validation
How did you test these changes?

• Did you build the app and test your changes?
• Did you check for accessibility? You can use Accessibility Insights for this.
• Did you remove any strings from the en-us resource file?
  • Did you search the solution to see if the string is still being used?
• Did you implement any design changes to an existing feature?
  • Was this change approved?
• Are there any other steps that were used to validate these changes?

[gumbarros]

LGTM to me, the changed method is the same from my debug.log from previous issues:

2024-04-05 19:35:03.0538|Error|System.AggregateException: A Task's exception(s) were not observed either by Waiting on the Task or accessing its Exception property. As a result, the unobserved exception was rethrown by the finalizer thread. ()
 ---> System.Runtime.InteropServices.COMException (0x800706F4)
   at WinRT.ExceptionHelpers.<ThrowExceptionForHR>g__Throw|39_0(Int32 hr)
   at ABI.Files.App.Server.Database.IFileTagsDatabaseClassMethods.SetTags(IObjectReference _obj, String filePath, Nullable`1 frn, String[] tags)
   at Files.App.Utils.FileTags.FileTagsHelper.UpdateTagsDb()

[hez2010]

Otherwise LGTM!

[hez2010]

We already asserted value is not null. I think we can keep here as it was.

[0x5bfa]

Isn't that for Debug condition?

[hishitetsu]

Debug.Assert is ignored in the release build, so I'm not sure if value is not null here.