Skip to content

Commit 9f884e5

Browse files
committed
delete conditionally
1 parent 3c0396d commit 9f884e5

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

tasks/pdp/watch_piece_delete.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,11 +232,15 @@ func processIndexingAndIPNICleanup(ctx context.Context, db *harmonydb.DB, cfg *c
232232
}
233233

234234
// Let's drop the PDP piece ref even if we don't publish the removal ad
235-
_, err = tx.Exec(`DELETE FROM pdp_piecerefs WHERE id = $1`, piece.PieceRef)
235+
n, err := tx.Exec(`DELETE FROM pdp_piecerefs WHERE id = $1 AND data_set_refcount = 0`, piece.PieceRef)
236236
if err != nil {
237237
return false, xerrors.Errorf("failed to delete PDP piece ref %d: %w", piece.PieceRef, err)
238238
}
239239

240+
if n != 1 {
241+
return false, xerrors.Errorf("expected to delete 1 row but deleted %d", n)
242+
}
243+
240244
_, err = tx.Exec(`DELETE FROM parked_piece_refs WHERE ref_id = $1`, piece.PieceRef)
241245
if err != nil {
242246
return false, xerrors.Errorf("failed to delete parked piece ref %d: %w", piece.PieceRef, err)

0 commit comments

Comments
 (0)