-
-
Notifications
You must be signed in to change notification settings - Fork 934
Expose ffprobe command from ffmpeg.wasm #776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for ffmpegwasm canceled.
|
2f8964b
to
2845a1b
Compare
…ENT variable was set to "WORKER". Node.js-related code should no longer be present in ffmpeg-core.js.
@izogfif do you know when this feature will be marged to main? |
@arielr I don't know. I have no relation to maintainers of ffmpeg.wasm and can't say when they decide to merge any pull request into ffmpeg.wasm repository. |
Please can someone merge this? |
+1 please merge! |
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
LOL i became a maintainer on this project specifically to merge this PR — @izogfif thank you so much |
lol glad to have this merged, ty |
ofc! @SimonHudec @izogfif the build is failing on my local machine so I'm struggling to deploy, any tips? I tried to publish the build artifacts produced in the GH action to npm, but the newest package still doesn't seem to have ffprobe exposed. Would love to get tue across the finish line if you have any tips, I also should have some time to actually figure out emscripten and debug this build myself after the holidays |
@lucasgelfond Please provide more details: what you do, what you expect to happen, and what happens instead. Clone repository https://github.com/izogfif/ffmpeg.wasm/tree/main and try building that version. Will it work for you? |
ffprobe.c
is already present insrc/fftools
folder. Let's expose it via.ffprobe
command!