Skip to content

Expose ffprobe command from ffmpeg.wasm #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

izogfif
Copy link

@izogfif izogfif commented Aug 29, 2024

ffprobe.c is already present in src/fftools folder. Let's expose it via .ffprobe command!

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for ffmpegwasm canceled.

Name Link
🔨 Latest commit bd903bb
🔍 Latest deploy log https://app.netlify.com/sites/ffmpegwasm/deploys/66d1ddb844cf6c000999ccc8

@izogfif izogfif force-pushed the main branch 3 times, most recently from 2f8964b to 2845a1b Compare August 30, 2024 10:28
…ENT variable was set to "WORKER". Node.js-related code should no longer be present in ffmpeg-core.js.
@arielr
Copy link

arielr commented Sep 3, 2024

@izogfif do you know when this feature will be marged to main?
Is there any other way access to ffprobe?

@izogfif
Copy link
Author

izogfif commented Sep 3, 2024

@izogfif do you know when this feature will be marged to main? Is there any other way access to ffprobe?

@arielr I don't know. I have no relation to maintainers of ffmpeg.wasm and can't say when they decide to merge any pull request into ffmpeg.wasm repository.
There is no built-in way to access ffprobe from the current ffpeg.wasm code. You can just clone the repository with this feature and build it yourself.

@SimonHudec
Copy link

Please can someone merge this?

@lucasgelfond
Copy link
Collaborator

+1 please merge!

@lucasgelfond

This comment was marked as off-topic.

Copy link
Collaborator

@lucasgelfond lucasgelfond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@lucasgelfond
Copy link
Collaborator

LOL i became a maintainer on this project specifically to merge this PR — @izogfif thank you so much

@lucasgelfond lucasgelfond merged commit 600f1d8 into ffmpegwasm:main Dec 23, 2024
4 checks passed
@SimonHudec
Copy link

lol glad to have this merged, ty

@lucasgelfond
Copy link
Collaborator

ofc! @SimonHudec @izogfif the build is failing on my local machine so I'm struggling to deploy, any tips? I tried to publish the build artifacts produced in the GH action to npm, but the newest package still doesn't seem to have ffprobe exposed. Would love to get tue across the finish line if you have any tips, I also should have some time to actually figure out emscripten and debug this build myself after the holidays

@izogfif
Copy link
Author

izogfif commented Jan 1, 2025

@lucasgelfond Please provide more details: what you do, what you expect to happen, and what happens instead. Clone repository https://github.com/izogfif/ffmpeg.wasm/tree/main and try building that version. Will it work for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants