Skip to content

Adds missing constructors #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 25, 2018
Merged

Adds missing constructors #7

merged 2 commits into from
Sep 25, 2018

Conversation

dantleech
Copy link
Contributor

@dantleech dantleech commented Sep 23, 2018 •
edited
Loading

This PR adds missing constructors for all but one class (ServerCapabiltiies).

  • All parameters are optional (in case making them required breaks the JSON mapper library or similar, could try this in another PR)

@felixfbecker felixfbecker merged commit 1bdd1bc into felixfbecker:master Sep 25, 2018
@felixfbecker
Copy link
Owner

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfbecker felixfbecker felixfbecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantleech @felixfbecker